diff --git a/lib/imap.php b/lib/imap.php index 046ba94..c162400 100644 --- a/lib/imap.php +++ b/lib/imap.php @@ -65,12 +65,12 @@ class OC_User_IMAP extends \OCA\user_external\Base { if(count($users) === 1) { $username = $uid; $uid = $users[0]; - // Check if we only want logins from ONE domain and strip the domain part from UID - }elseif($this->domain != '') { + // Check if we only want logins from ONE domain and strip the domain part from UID + }elseif($this->domain !== '') { $pieces = explode('@', $uid); - if(count($pieces) == 1) { + if(count($pieces) === 1) { $username = $uid . "@" . $this->domain; - }elseif((count($pieces) == 2) and ($pieces[1] == $this->domain)) { + }elseif((count($pieces) === 2) and ($pieces[1] === $this->domain)) { $username = $uid; $uid = $pieces[0]; }else{ @@ -79,7 +79,7 @@ class OC_User_IMAP extends \OCA\user_external\Base { }else{ $username = $uid; } - + $mbox = @imap_open($this->mailbox, $username, $password, OP_HALFOPEN, 1); imap_errors(); imap_alerts(); diff --git a/lib/smb.php b/lib/smb.php index f2595a1..7d16d18 100644 --- a/lib/smb.php +++ b/lib/smb.php @@ -53,7 +53,7 @@ class OC_User_SMB extends \OCA\user_external\Base{ } else if (strpos($lastline, 'NT_STATUS_BAD_NETWORK_NAME') !== false) { //login on minor error goto login; - } else if ($retval != 0) { + } else if ($retval !== 0) { //some other error OCP\Util::writeLog( 'user_external', 'ERROR: smbclient error: ' . trim($lastline), @@ -91,4 +91,3 @@ class OC_User_SMB extends \OCA\user_external\Base{ return false; } } - diff --git a/lib/webdavauth.php b/lib/webdavauth.php index 65ea7b7..a77adfe 100644 --- a/lib/webdavauth.php +++ b/lib/webdavauth.php @@ -34,7 +34,7 @@ class WebDavAuth extends Base { list($protocol, $path) = $arr; $url= $protocol.'://'.urlencode($uid).':'.urlencode($password).'@'.$path; $headers = get_headers($url); - if($headers==false) { + if($headers === false) { \OCP\Util::writeLog('OC_USER_WEBDAVAUTH', 'Not possible to connect to WebDAV Url: "'.$protocol.'://'.$path.'" ', 3); return false;