YakumoLabs/nextcloud-user_external
4
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Small performance improvement on imap_open

Browse Source 
Use the OP_HALFOPEN flag to reduce server load. We don't need to open a mailbox, so just don't try
I've also make the check clearer for the opened connection (I know, 2 PR in one, it's bad…)
This commit is contained in:
Glandos
2014-03-26 15:34:15 +01:00
parent f8bc0ccaf6
commit dc70d06144
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/imap.php
View File

@@ -42,10 +42,10 @@ class OC_User_IMAP extends \OCA\user_external\Base {
OCP\Util::writeLog('user_external', 'ERROR: PHP imap extension is not installed', OCP\Util::ERROR); OCP\Util::writeLog('user_external', 'ERROR: PHP imap extension is not installed', OCP\Util::ERROR);
return false; return false;
} }
$mbox = @imap_open($this->mailbox, $uid, $password); $mbox = @imap_open($this->mailbox, $uid, $password, OP_HALFOPEN);
imap_errors(); imap_errors();
imap_alerts(); imap_alerts();
if($mbox) { if($mbox !== FALSE) {
imap_close($mbox); imap_close($mbox);
$this->storeUser($uid); $this->storeUser($uid);
return $uid; return $uid;