From 58dd7465b9ca06c76c93e12879d950bc3d7d91e0 Mon Sep 17 00:00:00 2001 From: Anojh Thayaparan Date: Wed, 30 Jan 2019 08:10:11 -0800 Subject: [PATCH] check for errors before printing Signed-off-by: Anojh Thayaparan --- lib/imap.php | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/lib/imap.php b/lib/imap.php index b68b124..5e8dd75 100644 --- a/lib/imap.php +++ b/lib/imap.php @@ -67,14 +67,20 @@ class OC_User_IMAP extends \OCA\user_external\Base { } $mbox = @imap_open($this->mailbox, $username, $password, OP_HALFOPEN, 1); - OC::$server->getLogger()->error( - 'ERROR: IMAP Error: ' . print_r(imap_errors(), true), - ['app' => 'user_external'] - ); - OC::$server->getLogger()->warning( - 'WARNING: IMAP Warning: ' . print_r(imap_alerts(), true), - ['app' => 'user_external'] - ); + $imapErrors = imap_errors(); + $imapAlerts = imap_alerts(); + if (!empty($imapErrors) { + OC::$server->getLogger()->error( + 'ERROR: IMAP Error: ' . print_r($imapErrors, true), + ['app' => 'user_external'] + ); + } + if (!empty($imapAlerts)) { + OC::$server->getLogger()->warning( + 'WARNING: IMAP Warning: ' . print_r($imapAlerts, true), + ['app' => 'user_external'] + ); + } if($mbox !== false) { imap_close($mbox); $uid = mb_strtolower($uid);