YakumoLabs/user_external
4
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

basic authentication now follows redirects!

Browse Source 
Signed-off-by: Lutz Freitag <lutz@gottliebtfreitag.de>
This commit is contained in:
Lutz Freitag
2019-03-18 21:24:26 -06:00
parent 62911f8480
commit 816ec2e3f9
1 changed files with 22 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
lib/basicauth.php
View File

@@ -30,7 +30,7 @@ class OC_User_BasicAuth extends \OCA\user_external\Base {
'header' => "authorization: Basic " . base64_encode("$uid:$password") 'header' => "authorization: Basic " . base64_encode("$uid:$password")
)) ))
); );
$headers = get_headers($this->authUrl); $headers = get_headers($this->authUrl, 1);
if(!$headers) { if(!$headers) {
OC::$server->getLogger()->error( OC::$server->getLogger()->error(
@@ -39,13 +39,27 @@ class OC_User_BasicAuth extends \OCA\user_external\Base {
); );
return false; return false;
} }
/* get_headers() follows redirects up to a maximum (default: 20)
$returnCode= substr($headers[0], 9, 3); * the response code of the last request is stored in the numerically greatest item
if(substr($returnCode, 0, 1) === '2') { * $headers[0] is always present
$this->storeUser($uid); */
return $uid; $responseIdx = 0;
} else { foreach (array_keys($headers) as $key) {
return false; if (gettype($key) === "integer" && $responseIdx < $key) {
$responseIdx = $key;
}
} }
switch (substr($headers[$responseIdx], 9, 1)) {
case "2":
$this->storeUser($uid);
return $uid;
case "3":
OC::$server->getLogger()->error(
'ERROR: Too many redirects from BasicAuth Url: '.$this->authUrl,
['app' => 'user_external']
);
return false;
}
return false;
} }
} }