YakumoLabs/user_external
4
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Renaming the variable used for checs, adding more explanatory text

Browse Source 
Signed-off-by: Alejandro Liu <alejandro_liu@hotmail.com>
This commit is contained in:
Alejandro Liu
2019-06-01 19:18:53 +02:00
parent 2548a592f1
commit f03cd092fe
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/basicauth.php
View File

@@ -33,17 +33,17 @@ class OC_User_BasicAuth extends \OCA\user_external\Base {
'method'=>"GET", 'method'=>"GET",
)) ))
); );
$headers = get_headers($this->authUrl, 1); $canary = get_headers($this->authUrl, 1);
if(!$headers) { if(!$canary) {
OC::$server->getLogger()->error( OC::$server->getLogger()->error(
'ERROR: Not possible to connect to BasicAuth Url: '.$this->authUrl, 'ERROR: Not possible to connect to BasicAuth Url: '.$this->authUrl,
['app' => 'user_external'] ['app' => 'user_external']
); );
return false; return false;
} }
if (!isset($headers['WWW-Authenticate'])) { if (!isset($canary['WWW-Authenticate'])) {
OC::$server->getLogger()->error( OC::$server->getLogger()->error(
'ERROR: Mis-configured BasicAuth Url: '.$this->authUrl, 'ERROR: Mis-configured BasicAuth Url: '.$this->authUrl.', provided URL does not do authentication!',
['app' => 'user_external'] ['app' => 'user_external']
); );
return false; return false;