cocoa-devel/cocoa
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
ae23bbdae3102ebc187ff504fe07d75116815ff4
cocoa/models
History
zeripath 9c9c3348bb Prevent NPE on commenting on lines with invalidated comments (with migration) (#12549) 
* Prevent NPE on commenting on lines with invalidated comments

Only check for a review if we are replying to a previous review.

Prevent the NPE in #12239 by assuming that a comment without a Review is
non-pending.

Fix #12239

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Add hack around to show the broken comments

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Add migration and remove template hacks

Signed-off-by: Andrew Thornton <art27@cantab.net>
2020-08-21 10:53:14 +03:00
..
fixtures
Kanban board (#8346)
2020-08-16 23:07:38 -04:00
migrations
Prevent NPE on commenting on lines with invalidated comments (with migration) (#12549)
2020-08-21 10:53:14 +03:00
access_test.go
…
access.go
…
action_list.go
refactor: reduce sql query in retrieveFeeds (#3547)
2018-02-21 18:55:34 +08:00
action_test.go
…
action.go
Make dashboard newsfeed list length a configurable item (#12469)
2020-08-11 10:48:13 -04:00
admin_test.go
…
admin.go
Add a storage layer for attachments (#11387)
2020-08-18 12:23:45 +08:00
attachment_test.go
…
attachment.go
Add a storage layer for attachments (#11387)
2020-08-18 12:23:45 +08:00
avatar.go
…
branches_test.go
…
branches.go
Default empty merger list to those with write permissions (#12535)
2020-08-20 10:48:40 +03:00
commit_status_test.go
…
commit_status.go
…
consistency.go
Add migration to set IsArchived false if it is null (#11853)
2020-06-11 16:18:11 -04:00
context.go
Upgrade xorm to v1.0.2 (#11900)
2020-06-15 16:46:01 -04:00
convert.go
…
error_oauth2.go
…
error.go
Kanban board (#8346)
2020-08-16 23:07:38 -04:00
external_login_user.go
…
fixture_generation.go
…
fixture_test.go
…
gpg_key_test.go
…
gpg_key.go
Keys should not verify revoked email addresses (#12486)
2020-08-16 09:44:34 +01:00
helper_directory.go
Re-attempt to delete temporary upload if the file is locked by another process (#12447)
2020-08-11 21:05:34 +01:00
helper_environment.go
Move PushUpdateAddDeleteTags to repository module from models (#10106)
2020-02-03 09:47:04 +01:00
helper.go
…
issue_assignees_test.go
…
issue_assignees.go
Remove Unused Functions (#10516)
2020-03-02 00:05:44 +02:00
issue_comment_list.go
…
issue_comment_test.go
…
issue_comment.go
Kanban board (#8346)
2020-08-16 23:07:38 -04:00
issue_dependency_test.go
…
issue_dependency.go
…
issue_label_test.go
…
issue_label.go
Use ID or Where to instead directly use Get when load object from database (#11925)
2020-06-17 20:50:11 +03:00
issue_list_test.go
Add Organization Wide Labels (#10814)
2020-04-01 01:14:46 -03:00
issue_list.go
…
issue_lock.go
…
issue_milestone_test.go
Add name filter to API for GetMilestoneList (#12336)
2020-07-28 12:30:40 +01:00
issue_milestone.go
Kanban board (#8346)
2020-08-16 23:07:38 -04:00
issue_reaction_test.go
…
issue_reaction.go
…
issue_stopwatch_test.go
…
issue_stopwatch.go
When starting new stopwatch stop previous if it is still running (#10533)
2020-07-12 13:01:20 +03:00
issue_test.go
…
issue_tracked_time_test.go
…
issue_tracked_time.go
…
issue_user_test.go
Add "Update Branch" button to Pull Requests (#9784)
2020-01-17 08:03:40 +02:00
issue_user.go
Mail assignee when issue/pull request is assigned (#8546)
2019-10-25 22:46:37 +08:00
issue_watch_test.go
…
issue_watch.go
…
issue_xref_test.go
…
issue_xref.go
remove unused method and rename createcommentWithNoAction (#9367)
2019-12-16 11:54:24 +08:00
issue.go
Add a storage layer for attachments (#11387)
2020-08-18 12:23:45 +08:00
lfs_lock.go
Make repository management section handle lfs locks (#8726)
2019-12-12 21:18:07 +08:00
lfs.go
…
list_options.go
Use DEFAULT_PAGING_NUM instead of MAX_RESPONSE_ITEMS in ListOptions (#11831)
2020-06-10 12:23:22 -04:00
log.go
…
login_source.go
Use ID or Where to instead directly use Get when load object from database (#11925)
2020-06-17 20:50:11 +03:00
main_test.go
…
migrate.go
[BugFix] remove nil inserts in models (#11096)
2020-04-17 20:42:57 +03:00
models_test.go
…
models.go
Kanban board (#8346)
2020-08-16 23:07:38 -04:00
notification_test.go
…
notification.go
Extend Notifications API and return pinned notifications by default (#12164)
2020-07-12 00:46:01 +03:00
oauth2_application_test.go
OAuth2 Grant UI (#6625)
2019-04-17 16:18:16 +08:00
oauth2_application.go
Use google/uuid to instead satori/go.uuid (#11943)
2020-06-18 17:18:44 +08:00
oauth2.go
…
org_team_test.go
…
org_team.go
…
org_test.go
…
org.go
Fix bug preventing transfer to private organization (#12497)
2020-08-16 16:27:08 -04:00
project_board.go
Kanban board (#8346)
2020-08-16 23:07:38 -04:00
project_issue.go
Kanban board (#8346)
2020-08-16 23:07:38 -04:00
project_test.go
Kanban board (#8346)
2020-08-16 23:07:38 -04:00
project.go
Kanban board (#8346)
2020-08-16 23:07:38 -04:00
pull_list.go
API add/generalize pagination (#9452)
2020-01-24 14:00:29 -05:00
pull_sign.go
models: break out of loop (#12386)
2020-07-31 21:26:47 +08:00
pull_test.go
…
pull.go
Cache PullRequest Divergence (#10914)
2020-04-14 09:53:34 -04:00
release.go
…
repo_activity.go
…
repo_branch.go
…
repo_collaboration_test.go
…
repo_collaboration.go
Automatically remove Watches, Assignments, etc if user loses access due to being removed as collaborator or from a team (#10997)
2020-04-07 22:52:01 +01:00
repo_generate_test.go
…
repo_generate.go
…
repo_indexer.go
…
repo_issue.go
Add EnableTimetracking option to app settings (#3719)
2018-04-09 23:15:32 +08:00
repo_language_stats.go
Increase size of the language column in language_stat (#12396)
2020-08-04 14:54:29 +01:00
repo_list_test.go
…
repo_list.go
Fix repo-list private and total count bugs (#11500)
2020-05-20 22:15:30 -03:00
repo_mirror.go
Move some repository methods from models to modules/repository (#9353)
2019-12-14 18:30:01 +01:00
repo_permission_test.go
…
repo_permission.go
…
repo_redirect_test.go
…
repo_redirect.go
…
repo_sign.go
models: break out of loops (#12159)
2020-07-06 13:07:07 +01:00
repo_test.go
Decrease the num_stars when deleting a repo (#11954)
2020-07-07 15:16:34 -04:00
repo_unit.go
Kanban board (#8346)
2020-08-16 23:07:38 -04:00
repo_watch_test.go
…
repo_watch.go
Add action feed for new release (#12324)
2020-07-29 15:20:54 -04:00
repo.go
Add a storage layer for attachments (#11387)
2020-08-18 12:23:45 +08:00
review_test.go
Update Octicons to v10 (#12240)
2020-07-17 18:15:12 +03:00
review.go
Update Octicons to v10 (#12240)
2020-07-17 18:15:12 +03:00
ssh_key_test.go
Fix SSH2 conditonal in key parsing code (#8806)
2019-11-03 19:08:18 +08:00
ssh_key.go
Re-attempt to delete temporary upload if the file is locked by another process (#12447)
2020-08-11 21:05:34 +01:00
star_test.go
API add/generalize pagination (#9452)
2020-01-24 14:00:29 -05:00
star.go
…
task.go
…
test_fixtures.go
upgrade to use testfixtures v3 (#11904)
2020-06-17 22:07:58 +03:00
token_test.go
…
token.go
Use google/uuid to instead satori/go.uuid (#11943)
2020-06-18 17:18:44 +08:00
topic_test.go
API add/generalize pagination (#9452)
2020-01-24 14:00:29 -05:00
topic.go
Update topics repo count when deleting repository (#10051)
2020-01-31 08:57:19 +02:00
twofactor.go
Use ID or Where to instead directly use Get when load object from database (#11925)
2020-06-17 20:50:11 +03:00
u2f_test.go
Add gitea-vet (#10948)
2020-04-05 07:20:50 +01:00
u2f.go
…
unit_tests.go
Add a storage layer for attachments (#11387)
2020-08-18 12:23:45 +08:00
unit.go
Kanban board (#8346)
2020-08-16 23:07:38 -04:00
update.go
Remove Unused Functions (#10516)
2020-03-02 00:05:44 +02:00
upload.go
Re-attempt to delete temporary upload if the file is locked by another process (#12447)
2020-08-11 21:05:34 +01:00
user_follow_test.go
Add gitea-vet (#10948)
2020-04-05 07:20:50 +01:00
user_follow.go
…
user_heatmap_test.go
…
user_heatmap.go
Add hide activity option (#11353)
2020-06-05 16:01:53 -04:00
user_mail_test.go
Admin page for managing user e-mail activation (#10557)
2020-03-02 15:25:36 -03:00
user_mail.go
Use ID or Where to instead directly use Get when load object from database (#11925)
2020-06-17 20:50:11 +03:00
user_openid_test.go
Add golangci (#6418)
2019-06-12 15:41:28 -04:00
user_openid.go
Use ID or Where to instead directly use Get when load object from database (#11925)
2020-06-17 20:50:11 +03:00
user_test.go
…
user.go
Fix bug preventing transfer to private organization (#12497)
2020-08-16 16:27:08 -04:00
userlist_test.go
Team permission to create repository in organization (#8312)
2019-11-20 19:27:49 +08:00
userlist.go
API add/generalize pagination (#9452)
2020-01-24 14:00:29 -05:00
webhook_test.go
Granular webhook events (#9626)
2020-03-06 07:10:48 +02:00
webhook.go
Use google/uuid to instead satori/go.uuid (#11943)
2020-06-18 17:18:44 +08:00
wiki_test.go
Move wiki related funtions from models to services/wiki (#9355)
2020-01-07 18:27:36 +00:00
wiki.go
…