shinyoukai/mai
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make some identifiers more concise

Browse Source 
See https://go.dev/doc/effective_go#package-names, specifically:

> The importer of a package will use the name to refer to its contents,
> so exported names in the package can use that fact to avoid
> repetition.

For example, `engines.GoogleTranslateEngine` needlessly repeats
"engine," so just get rid of that duplication by renaming it to
`engines.GoogleTranslate`.

Renaming `engines.TranslationEngine` to `engines.Engine` may be
debatable, so if somebody disagrees, feel free to leave a comment
stating your disagreement and with an explanation of why you disagree.

git-svn-id: file:///srv/svn/repo/mai/trunk@10 e410bdd4-646f-c54f-a7ce-fffcc4f439ae
This commit is contained in:
fattalion
2022-09-30 20:16:23 +00:00
parent c4d051d74f
commit 41fff3c53b
5 changed files with 30 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
engines/google.go
View File

@@ -8,13 +8,13 @@ import (
"github.com/PuerkitoBio/goquery"
)
type GoogleTranslateEngine struct{}
type GoogleTranslate struct{}
func (_ *GoogleTranslateEngine) InternalName() string { return "google" }
func (_ *GoogleTranslate) InternalName() string { return "google" }
func (_ *GoogleTranslateEngine) DisplayName() string { return "Google" }
func (_ *GoogleTranslate) DisplayName() string { return "Google" }
func (_ *GoogleTranslateEngine) getLangs(type_ string) ([]Language, error) {
func (_ *GoogleTranslate) getLangs(type_ string) ([]Language, error) {
var langsType string
switch type_ {
case "source":
@@ -83,19 +83,19 @@ func (_ *GoogleTranslateEngine) getLangs(type_ string) ([]Language, error) {
return langs, nil
}
func (e *GoogleTranslateEngine) SourceLanguages() ([]Language, error) {
func (e *GoogleTranslate) SourceLanguages() ([]Language, error) {
return e.getLangs("source")
}
func (e *GoogleTranslateEngine) TargetLanguages() ([]Language, error) {
func (e *GoogleTranslate) TargetLanguages() ([]Language, error) {
return e.getLangs("target")
}
func (_ *GoogleTranslateEngine) SupportsAutodetect() bool { return true }
func (_ *GoogleTranslate) SupportsAutodetect() bool { return true }
func (_ *GoogleTranslateEngine) DetectLanguage(text string) (Language, error) { return Language{}, nil }
func (_ *GoogleTranslate) DetectLanguage(text string) (Language, error) { return Language{}, nil }
func (_ *GoogleTranslateEngine) Translate(text string, from Language, to Language) (TranslationResult, error) {
func (_ *GoogleTranslate) Translate(text string, from Language, to Language) (TranslationResult, error) {
requestURL, err := url.Parse("https://translate.google.com/m")
if err != nil {