shinyoukai/mai
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make some identifiers more concise

Browse Source 
See https://go.dev/doc/effective_go#package-names, specifically:

> The importer of a package will use the name to refer to its contents,
> so exported names in the package can use that fact to avoid
> repetition.

For example, `engines.GoogleTranslateEngine` needlessly repeats
"engine," so just get rid of that duplication by renaming it to
`engines.GoogleTranslate`.

Renaming `engines.TranslationEngine` to `engines.Engine` may be
debatable, so if somebody disagrees, feel free to leave a comment
stating your disagreement and with an explanation of why you disagree.

git-svn-id: file:///srv/svn/repo/mai/trunk@10 e410bdd4-646f-c54f-a7ce-fffcc4f439ae
This commit is contained in:
fattalion
2022-09-30 20:16:23 +00:00
parent c4d051d74f
commit 41fff3c53b
5 changed files with 30 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
engines/iciba.go
View File

@@ -9,12 +9,12 @@ import (
"net/url"
)
// ICIBAEngine is an engine that fetches data from https://www.iciba.com.
type ICIBAEngine struct{}
// ICIBA is an engine that fetches data from https://www.iciba.com.
type ICIBA struct{}
func (_ *ICIBAEngine) InternalName() string { return "iciba" }
func (_ *ICIBA) InternalName() string { return "iciba" }
func (_ *ICIBAEngine) DisplayName() string { return "iCIBA" }
func (_ *ICIBA) DisplayName() string { return "iCIBA" }
var icibaLanguages = []Language{
// ICIBA does have an API, but they return Chinese names.
@@ -211,13 +211,13 @@ var icibaLanguages = []Language{
{Name: "Zulu", Code: "zu"},
}
func (_ *ICIBAEngine) SourceLanguages() ([]Language, error) { return icibaLanguages, nil }
func (_ *ICIBA) SourceLanguages() ([]Language, error) { return icibaLanguages, nil }
func (_ *ICIBAEngine) TargetLanguages() ([]Language, error) { return icibaLanguages, nil }
func (_ *ICIBA) TargetLanguages() ([]Language, error) { return icibaLanguages, nil }
func (_ *ICIBAEngine) SupportsAutodetect() bool { return true }
func (_ *ICIBA) SupportsAutodetect() bool { return true }
func (_ *ICIBAEngine) DetectLanguage(text string) (Language, error) { return Language{}, nil }
func (_ *ICIBA) DetectLanguage(text string) (Language, error) { return Language{}, nil }
type icibaTranslateResponse struct {
Content struct {
@@ -226,7 +226,7 @@ type icibaTranslateResponse struct {
} `json:"content"`
}
func (_ *ICIBAEngine) Translate(text string, from Language, to Language) (TranslationResult, error) {
func (_ *ICIBA) Translate(text string, from Language, to Language) (TranslationResult, error) {
requestURL, err := url.Parse("https://ifanyi.iciba.com/index.php")
if err != nil {