YakumoLabs/user_external
4
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix for #141

Browse Source 
* Authorization header for OC_User_BasicAuth is now set with locally stream context instead globally with stream_context_set_default function.
* HTTP Redirects in OC_User_BasicAuth are disabled now, so authorization header can not be forwared to foreign servers.
Closes #141

Signed-off-by: Björn Voigt <bjoernv@arcor.de>
This commit is contained in:
bjoernv
2020-04-22 23:31:36 +02:00
committed by Björn Voigt
parent 132e8b6c55
commit 133d3405d0
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
lib/basicauth.php
View File

@@ -28,12 +28,13 @@ class OC_User_BasicAuth extends \OCA\user_external\Base {
* Connect without user/name password to make sure
* URL is indeed authenticating or not...
*/
stream_context_set_default(array(
'http'=>array(
'method'=>"GET",
$context = stream_context_create(array(
'http' => array(
'method' => "GET",
'follow_location' => 0
))
);
$canary = get_headers($this->authUrl, 1);
$canary = get_headers($this->authUrl, 1, $context);
if(!$canary) {
OC::$server->getLogger()->error(
'ERROR: Not possible to connect to BasicAuth Url: '.$this->authUrl,
@@ -49,13 +50,14 @@ class OC_User_BasicAuth extends \OCA\user_external\Base {
return false;
}
stream_context_set_default(array(
'http'=>array(
'method'=>"GET",
'header' => "authorization: Basic " . base64_encode("$uid:$password")
$context = stream_context_create(array(
'http' => array(
'method' => "GET",
'header' => "authorization: Basic " . base64_encode("$uid:$password"),
'follow_location' => 0
))
);
$headers = get_headers($this->authUrl, 1);
$headers = get_headers($this->authUrl, 1, $context);
if(!$headers) {
OC::$server->getLogger()->error(